feat: unified combiner for multiple signing schemes aggregation #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igning schemes signature aggregation
…007-js-sdk-add-frost-support-unified-combiner # Conflicts: # local-tests/tests/testUseEoaSessionSigsToPkpSign.ts # packages/constants/src/lib/constants/curves.ts # packages/core/src/lib/lit-core.ts # packages/crypto/src/lib/crypto.ts # packages/lit-node-client-nodejs/src/lib/lit-node-client-nodejs.ts # packages/pkp-base/src/lib/pkp-base.ts # packages/types/src/lib/interfaces.ts
…e extra validation leaving it as consumer responsibility
FedericoAmura
requested review from
DashKash54,
MaximusHaximus and
mikelodder7
14 tasks
Ansonhkg
approved these changes
Mar 11, 2025
Collaborator
Ansonhkg
left a comment
Ansonhkg
left a comment
There was a problem hiding this comment.
nit: I think we can use zod for all data transformation, but we can have a follow up PR for that later.
| devEnv: TinnyEnvironment | ||
| ) => { | ||
| const alice = await devEnv.createRandomPerson(); | ||
| const signingSchemeConfigs: SigningSchemeConfig[] = [ |
Collaborator
There was a problem hiding this comment.
do we have this config in constants?
Contributor
Author
There was a problem hiding this comment.
No. This is just to apply more validations later in this test. Doesn't have much value in real scenarios as we are not doing signature parsing or validation anymore
| throw new Error(`Expected "publicKey" in runWithSessionSigs`); | ||
| } | ||
| // -- Combined signature format assertions | ||
| for (const hexString of [ |
Collaborator
There was a problem hiding this comment.
nit: can we use zod schema instead?
| if (!runWithSessionSigs.signature.startsWith('0x')) { | ||
| throw new Error(`Expected "signature" to start with 0x`); | ||
| } | ||
| if (signingSchemeConfig.recoversPublicKey) { |
Collaborator
There was a problem hiding this comment.
nit: can we use zod schema here?
eg.
const validConfig = SigningSchemeConfigSchema.parse(signingSchemeConfig);
const validSignature = PKPSignatureSchema.parse(pkpSignature);
FedericoAmura
deleted the
feature/lit-4007-js-sdk-add-frost-support-unified-combiner
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds multiple signing schemes (Ecdsa and Frost) support sending such scheme to the nodes
Migration guide
SigTypeto define signing schemesLitNodeClientNodeJs::pkpSign,LitNodeClientNodeJs::ExecuteJsResponse,PKPBase (and childs)::runLitAction/runSignall now returnLitNodeSignatures which include0x${string}values instead of generic strings in hex and{ r, s }signatures. all their types have been updatedLitNodeClientNodeJs::pkpSignnow takes the plain message inmessageToSignparam instead of the hashed valuetoSign(unifying frost and ecdsa behaviour, hashing internally when the signing scheme requires it). Also requires the newsigningSchemeparamLitNodeClientNodeJs::executeJsreturns all keys that it signs, not just the first oneLitCore::computeHDPubKeydoesn't accept signing scheme anymore. Will always use ECDSA K256 (where PKPs live). Same for @lit-protocol/cryptocomputeHDPubKeydecryptWithSignatureSharescombineEcdsaSharesreplaced withcombineExecuteJsNodeSharesandcombinePKPSignNodeSharesecdsaCombine,ecdsaVerifyandecdsaCombineAndVerify. All replaced withunifiedCombineAndVerifyDev changes
Most notable change will be in
litNodeClient.pkpSignthat now requires the unhashed message inmessageToSignand a signing scheme,SchnorrK256Sha256will replicate previous networks behaviorWhen using
pkpSign,executeJsfrom LitNodeClient or any PKP*Wallet, now consider that the returned signature will be in0x${string}format and not have anymore components{ r, s }Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
testUseEoaSessionSigsToPkpSignto call pkpSign with all supported signing schemesChecklist: